Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade serde_yaml #701

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

CeerDecy
Copy link

@CeerDecy CeerDecy commented Sep 6, 2024

What this PR does / why we need it:

the package yaml-rust seems unmaintained, and the serde_yaml v0.8.26 depends on it, so upgrade the serde_yaml version to 0.9.
The new version of serde_yaml no longer supports the syntax standard: {} to automatically inject default values for enum types, need to add singleton_map annotations in discovery-handlers/opcua/src/discovery_handler.rs Line 55. references serde_yaml issue

closes #693

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: CeerDecy <[email protected]>
@CeerDecy CeerDecy marked this pull request as ready for review September 9, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0320: yaml-rust is unmaintained.
1 participant