Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct test case test_validate_valid_jobspec #629

Merged
merged 1 commit into from
Jul 17, 2023
Merged

correct test case test_validate_valid_jobspec #629

merged 1 commit into from
Jul 17, 2023

Conversation

johnsonshih
Copy link
Contributor

@johnsonshih johnsonshih commented Jul 11, 2023 •
edited
Loading

What this PR does / why we need it:
There is a typo in the unit test test_validate_valid_jobspec, it should test valid job spec, not valid pod spec.
Special notes for your reviewer:

/add-same-version-label

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@johnsonshih
Copy link
Contributor Author

/add-same-version-label

@github-actions
Copy link
Contributor

👋 Added [same version] label :)!

@github-actions
Copy link
Contributor

👋 Added [same version] label :)!

@johnsonshih johnsonshih merged commit cdd1ae5 into project-akri:main Jul 17, 2023
6 of 7 checks passed
@johnsonshih johnsonshih deleted the user/jshih/webhook-test_validate_valid_jobspec branch July 17, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diconico07 diconico07 diconico07 approved these changes

@bfjelds bfjelds Awaiting requested review from bfjelds bfjelds is a code owner

@kate-goldenring kate-goldenring Awaiting requested review from kate-goldenring kate-goldenring is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

@adithyaj adithyaj Awaiting requested review from adithyaj adithyaj is a code owner

Assignees
No one assigned
Labels
same version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsonshih @diconico07