udev: Fix error when using Rust 1.70 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diconico07
requested review from
bfjelds,
kate-goldenring,
jiria,
Britel,
romoh,
adithyaj and
johnsonshih
as code owners
diconico07
force-pushed
the
fix_bindings_with_variant_name
branch
from
88f0bd9
to
741d1b4
Compare
bfjelds
approved these changes
Jul 20, 2023
The `bindings_with_variant_name` is set to deny by default since 1.68.0, it seems it wasn't correctly enforced back then as the error only triggers with a rustc >=1.70 here. This commit just rename the binding that use a variant name, this way we don't trigger this error. Signed-off-by: Nicolas Belouin <[email protected]>
Signed-off-by: Nicolas Belouin <[email protected]>
diconico07
force-pushed
the
fix_bindings_with_variant_name
branch
from
741d1b4
to
827978b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
bindings_with_variant_nameis set to deny by default since 1.68.0, it seems it wasn't correctly enforced back then as the error only triggers with a rustc >=1.70 here.This commit just rename the binding that use a variant name, this way we don't trigger this error.
While not needed as of now (we are still using 1.68.1 version), this change will likely make the move to newer versions of Rust easier
Special notes for your reviewer:
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)