Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mounting of Kubernetes Secrets via Helm Chart #477

Closed
hemantkathuria opened this issue May 11, 2022 · 1 comment · Fixed by #478
Closed

Allow mounting of Kubernetes Secrets via Helm Chart #477

hemantkathuria opened this issue May 11, 2022 · 1 comment · Fixed by #478
Labels
good first issue Good for newcomers

Comments

@hemantkathuria
Copy link

Is your feature request related to a problem? Please describe.
Current Helm Chart does not allow a way to load Kubernetes Secrets as Environment Variables. It is a very common use case to load secrets as Environment variables

Describe the solution you'd like
Allow loading Secrets from envFrom etc.

Describe alternatives you've considered
As suggested used the Helm Template command, modified the POD specification and applied the same. But this is not neat and not maintainable.

@kate-goldenring
Copy link
Contributor

@hemantkathuria this is an important addition. As you mentioned, a Configuration with secrets added via envFrom could be generated as follows:

helm template akri akri-helm-charts/akri \
    --set rbac.enabled=false \
    --set controller.enabled=false \
    --set agent.enabled=false \
    --set opcua.configuration.enabled=true \
    --set opcua.configuration.brokerPod.image.repository=nginx \
    --set opcua.configuration.mountCertificates=true > configuration.yaml
# Modify configuration.yaml to include envFrom and correct volumes.

However, it would be better if Akri's helm chart supported setting envFrom just as it does support standard environment variables in a PodSpec. I.e.:

udev:
  configuration:
    brokerPod:
      env:
        FORMAT: JPEG
        RESOLUTION_WIDTH: 1000

Support can be added by adding a {{- if .Values.protocol.configuration.brokerPod.envFrom }} conditional to each Configuration Helm template as done for environment variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
2 participants