Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resource watcher instead of Api::watch #374

Closed
kate-goldenring opened this issue Sep 8, 2021 · 0 comments · Fixed by #378
Closed

Use resource watcher instead of Api::watch #374

kate-goldenring opened this issue Sep 8, 2021 · 0 comments · Fixed by #378
Assignees

Comments

@kate-goldenring
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Akri's Agent and Controller watch Pods, Nodes, Instances, and Configuration resources from the Kubernetes API Server. Currently, these watches are done using the kube-rs Api::watch function. Now that we have updated to the latest tokio versions in #361, we can take advantage of kube-rs's watcher function, which, compared to Api::watch, will automatically try to recover the stream upon errors."

Describe the solution you'd like
Change these to use watcher:
Instance watcher
Node watcher
Pod watcher
Configuration watcher

Additional context
This may help solve #222 if it can handle disconnects with API server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant