chore(api)!: dedupe career site and seo settings

Author: amandesai01

server/api/public/settings.get.ts

@@ -1,45 +1,25 @@
-import { z } from 'zod';
-import { type GeneralSettings } from '~~/shared/schemas/setting';
+import {
+  type SEOConfig,
+  type CareerSiteConfig,
+} from '~~/shared/schemas/setting';
 import { settings_memoryStorage } from '~~/server/utils/storage';
 
-const settingsLookupSchema = z.object({
-  config: z.enum(['seoConfig', 'careerSiteConfig']).optional(),
-});
-
-export default defineEventHandler(async (event) => {
-  const query = await getValidatedQuery(event, settingsLookupSchema.parse);
-  const queries = query.config
-    ? [query.config]
-    : ['seoConfig', 'careerSiteConfig'];
-
+export default defineEventHandler(async () => {
   if (IS_DEV) {
-    console.log('fetching public settings. queries:', queries);
+    console.log('fetching public settings');
   }
 
-  const settings: GeneralSettings = {
+  const settings = {
     careerSite: {},
     seo: {},
-  } as GeneralSettings; // Ignore validation errors here.
+  } as { careerSite: CareerSiteConfig; seo: SEOConfig };
 
-  for (let index = 0; index < queries.length; index++) {
-    const query = queries[index];
-    let value: any;
-    switch (query) {
-      case 'seoConfig':
-        value = await settings_memoryStorage.getItem(query);
-        settings.seo = value as GeneralSettings['seo'];
-        break;
-      case 'careerSiteConfig':
-        value = await settings_memoryStorage.getItem(query);
-        settings.careerSite = value as GeneralSettings['careerSite'];
-        break;
-      default:
-        throw createError({
-          statusCode: 404,
-          statusMessage: `no config with key ${query} found`,
-        });
-    }
-  }
+  settings.seo = (await settings_memoryStorage.getItem(
+    'seoConfig'
+  )) as SEOConfig;
+  settings.careerSite = (await settings_memoryStorage.getItem(
+    'careerSiteConfig'
+  )) as CareerSiteConfig;
 
   return settings;
 });

server/api/settings/career-site.get.ts

@@ -0,0 +1,10 @@
+import { type CareerSiteConfig } from '~~/shared/schemas/setting';
+import authenticateAdminRequest from '~~/server/utils/admin';
+
+export default defineEventHandler(async (event) => {
+  await authenticateAdminRequest(event);
+
+  return (await settings_memoryStorage.getItem(
+    'careerSiteConfig'
+  )) as CareerSiteConfig;
+});

server/api/settings/career-site.put.ts

@@ -0,0 +1,27 @@
+import { eq } from 'drizzle-orm';
+import { careerSiteConfigSchema } from '~~/shared/schemas/setting';
+import { metaDataTable } from '~~/server/db/schema';
+import authenticateAdminRequest from '~~/server/utils/admin';
+import { settings_memoryStorage } from '~~/server/utils/storage';
+
+export default defineEventHandler(async (event) => {
+  await authenticateAdminRequest(event);
+
+  if (IS_DEV) {
+    console.log('updating careerSiteConfig');
+  }
+
+  const settingsUpdateRequest = await readValidatedBody(
+    event,
+    careerSiteConfigSchema.parse
+  );
+
+  const db = await useDatabase();
+
+  const careerSiteString = JSON.stringify(settingsUpdateRequest);
+  await db
+    .update(metaDataTable)
+    .set({ value: careerSiteString, updatedAt: new Date() })
+    .where(eq(metaDataTable.key, 'careerSiteConfig'));
+  settings_memoryStorage.setItem('careerSiteConfig', settingsUpdateRequest);
+});

server/api/settings/general.get.ts

@@ -0,0 +1,8 @@
+import { type SEOConfig } from '~~/shared/schemas/setting';
+import authenticateAdminRequest from '~~/server/utils/admin';
+
+export default defineEventHandler(async (event) => {
+  await authenticateAdminRequest(event);
+
+  return (await settings_memoryStorage.getItem('seoConfig')) as SEOConfig;
+});

server/api/settings/general.put.ts

@@ -0,0 +1,27 @@
+import { eq } from 'drizzle-orm';
+import { careerSiteConfigSchema } from '~~/shared/schemas/setting';
+import { metaDataTable } from '~~/server/db/schema';
+import authenticateAdminRequest from '~~/server/utils/admin';
+import { settings_memoryStorage } from '~~/server/utils/storage';
+
+export default defineEventHandler(async (event) => {
+  await authenticateAdminRequest(event);
+
+  if (IS_DEV) {
+    console.log('updating seoConfig');
+  }
+
+  const settingsUpdateRequest = await readValidatedBody(
+    event,
+    careerSiteConfigSchema.parse
+  );
+
+  const db = await useDatabase();
+
+  const careerSiteString = JSON.stringify(settingsUpdateRequest);
+  await db
+    .update(metaDataTable)
+    .set({ value: careerSiteString, updatedAt: new Date() })
+    .where(eq(metaDataTable.key, 'seoConfig'));
+  settings_memoryStorage.setItem('seoConfig', settingsUpdateRequest);
+});

server/api/settings/seo.get.ts

@@ -34,14 +34,7 @@ export const careerSiteConfigSchema = z.object({
   ),
 });
 
-export type careerSiteConfig = z.infer<typeof careerSiteConfigSchema>;
-
-export const generalSettingsSchema = z.object({
-  careerSite: careerSiteConfigSchema,
-  seo: seoConfigSchema,
-});
-
-export type GeneralSettings = z.infer<typeof generalSettingsSchema>;
+export type CareerSiteConfig = z.infer<typeof careerSiteConfigSchema>;
 
 export const addMemberSchema = z.object({
   id: z.string().uuid(),