Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPOSE_VARS secret will leak base64 encoded if copied to stdout|err|terminal #236

Closed
ab77 opened this issue Sep 27, 2022 · 2 comments
Closed
Labels
invalid This doesn't seem right

Comments

@ab77
Copy link
Member

ab77 commented Sep 27, 2022

Since the COMPOSE_VARS is base64 encoded before being stored as a secret, only the base64 encoded value will be protected from leakage by GH actions runners.

Once the value is unwrapped, GH runners will no longer match the secret hash and if the value makes it to some output, the secret values will leak into the runner logs.

@ab77 ab77 added the invalid This doesn't seem right label Sep 27, 2022
@klutchell klutchell reopened this Nov 30, 2022
@klutchell
Copy link
Collaborator

Related to #332

For external contributions this secret is not allowed and will exit the workflow. However there is still the possibility for internal contributors to accidentally leak this value and as such it should be deprecated.

@ab77
Copy link
Member Author

ab77 commented Jan 12, 2023

@ab77 ab77 closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants