-
Notifications
You must be signed in to change notification settings - Fork 11
Containerise and add automatic builds #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks fot the commit , it will take some time to review it (i am very busy at the moment) |
Sorry the commit history is a bit messy - I did a bunch of this work late in the evening, and of course changes on GitHub workflows especially aren't really a thing one can test without pushing them and running the workflow... FWIW I'm using the images built from this on my home server now; if you've got Docker to hand you can try them out via the image |
@fpiesche Thank you! I tried your docker version ghcr.io/fpiesche/nspindexer:2022.08.16 and every little problems I had with the original version are gone! I was unable to rename certain NSZ, the log file would grow infinitly with errors :( Now everything works like it should. |
This does a number of things:
config.default.php
to allow overriding configuration with environment variables (which is the standard way of setting up simple configuration in Docker containers)index.php
to make it easier to see what's going on (and disable Apache's access logging in the Docker container so it doesn't spam up the log)Additionally:
titles.json
orversions.json
(e.g. 0100696014F4A000 or 0100E2F014F46000). This would cause the indexer to crash when trying to parse the release date field; now these cases are handled gracefully and parsed sensibly, and the indexer logs a warning about the missing data in the Tinfoil databases!