Replaced calls to random by rand
#414
Conversation
Deprecated since Erlang/OTP 19. Link: https://www.erlang.org/doc/deprecations.html#functions-deprecated-in-otp-19 Signed-off-by: Ariel Otilibili <[email protected]>
Deprecated since Erlang/OTP 19. Link: https://www.erlang.org/doc/deprecations.html#functions-deprecated-in-otp-19 Signed-off-by: Ariel Otilibili <[email protected]>
Deprecated since Erlang/OTP 19. Link: https://www.erlang.org/doc/deprecations.html#functions-deprecated-in-otp-19 Signed-off-by: Ariel Otilibili <[email protected]>
Deprecated since Erlang/OTP 19. Link: https://www.erlang.org/doc/deprecations.html#functions-deprecated-in-otp-19 Signed-off-by: Ariel Otilibili <[email protected]>
ariel-anieli
force-pushed
the
deprecation-random
branch
from
ba33b56 to
0b35269
Compare
|
Look good. |
Thanks, @prefiks; I'll push other PRs in coming days; for clearing out warnings in OTP 23. |
|
The calls to rand:seed seem wrong, see https://www.erlang.org/doc/apps/stdlib/rand.html#seed/2 There's no seed/3 accepting a state without an algorithm, as implied by the merged code, which results in runtime failures. At a first glance, when using the rand module instead of random, some seed calls appear gratuitous. |
| {timeout,Ref2,end_thinktime} -> ok | ||
| end, | ||
| random:seed(), % reinit seed for others tests | ||
| rand:seed(), % reinit seed for others tests |
There was a problem hiding this comment.
Is that even needed? The rand module is autoseeded...
| %%%=================================================================== | ||
| gen_accept_key() -> | ||
| random:seed(erlang:now()), | ||
| rand:seed(erlang:now()), |
There was a problem hiding this comment.
What's the point of trying to seed here? crypto:strong_rand_bytes/1 takes care of that, no?
PR processone#414 fixed compilation warnings but broke tsung at runtime. See https://www.erlang.org/docs/25/man/rand#seed-2
PR processone#414 fixed compilation warnings but broke tsung at runtime. See https://www.erlang.org/docs/25/man/rand#seed-2
|
I am just reading your feedback, @VlkrS; it is much appreciated.
I will then push the fixes. |
3 participants
Hello committers,
Thanks for maintaining this project. I would like to bring back to the community, and also to improve my Erlang skills.
Here is the first of few PRs on clearing out compilation warnings. For this one,
randomis deprecated since Erlang/OTP 19.Thank you,