Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative regex for resolving issue#606 #729

Merged
merged 10 commits into from
Jul 13, 2023

Conversation

WillRabalais04
Copy link
Contributor

Closes #606

WillRabalais04 and others added 8 commits March 24, 2023 01:47
Updates the getStringValue method of the VariableNode class so that it correctly handles multidimensional arrays. The default formatting of multidimensional arrays is to have the size of the first array written in the last set of brackets eg.int[][5]. This changes it so that the returned value has the size of the first array written in the first set of brackets eg.int[5][]. This can parse multidimensional arrays of any size.
Closes Debugger lists immediate array dimension last benfry#606.
@sampottinger sampottinger self-requested a review June 8, 2023 16:32
Copy link
Collaborator

@sampottinger sampottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these great builds @WillRabalais04 !

@sampottinger
Copy link
Collaborator

Merging to help #749 maintain a clean diff.

@sampottinger sampottinger merged commit 6cba79b into benfry:main Jul 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger lists immediate array dimension last
2 participants