Fix static mode visibility injection when annotation present #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampottinger
commented
Dec 10, 2022
| @@ -591,7 +591,7 @@ public void exitMethodDeclaration(ProcessingParser.MethodDeclarationContext ctx) | |||
| if (annoationPoint == null) { | |||
| insertBefore(possibleModifiers.getStart(), "public "); | |||
| } else { | |||
| insertAfter(annoationPoint.getStop(), "public "); | |||
| insertAfter(annoationPoint.getStop(), " public "); | |||
There was a problem hiding this comment.
@benfry this is the actual fix. Everything else in this PR is just adding additional tests to prevent regressions.
sampottinger
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #619 - There is a problem with adding public to members when wrapping in “static” mode processing sketches introduced by removing the leading space in #609. Requires preproc to look for leading annnotations before injecting visibility modifier. Apologies @benfry and @knupel.