Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --full-screen option from export window #502

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

sampottinger
Copy link
Collaborator

@sampottinger sampottinger commented Jun 21, 2022

Fixes #488. Clean up the footer writer section of the preprocessor for easier reading but also fix adding and looking for --full-screen which appears to have been left off at some point. Specifically:

  • Though not the source of the issue, the footer writer section of the PdeParseTreeListener was a little hard to read so cleaned up that code slightly.
  • Found the issue with the handling of --full-screen which required a change in PApplet
  • Added tests for the full screen export option for the parser / preprocessing

Clean up the footer writer section of the preprocessor for easier reading but also fix adding and looking for --full-screen which appears to have been left off at some point.
@sampottinger sampottinger requested a review from benfry June 21, 2022 15:38
@benfry benfry merged commit 3fb516a into master Jul 12, 2022
@benfry benfry deleted the full_screen_preproc_fix branch July 12, 2022 15:42
@benfry
Copy link
Owner

benfry commented Jul 12, 2022

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Application gives java.lang.ClassNotFoundException: --full-screen error
2 participants