Text assets's content-type is always text/html

[kazuhikoarase]

Nature of issue?

• Found a bug

Details about the bug:

• Web browser and version: Chrome
• Operating System: Windows
• Steps to reproduce this bug:

I found getFileContent function at /p5.js-web-editor/server/controllers/file.controller.js
But there are nothing considered about content-type and rely on default behavior.

Express official document says

When the parameter is a Buffer object, the method sets the Content-Type response header field to “application/octet-stream”

When the parameter is a String, the method sets the Content-Type to “text/html”

https://expressjs.com/en/api.html#res.send

I think that it should be text/javascript(or application/javascript) for .js, application/json for .json and so on.

Thank you.

[catarak]

Thanks for reporting! This is definitely a bug, related to #496 but fixing this in a different place.

[ashu8912]

Hey @catarak can you guide me where to start to fix this one.

[catarak]

You'll need to edit the function getFileContent to change the MIME type based on the file extension.

[ashu8912]

ok sending in a pr soon

[sorcerix]

Is anyone working on this?