Skip to content
This repository has been archived by the owner on Feb 28, 2021. It is now read-only.

look into vulnerabilities #130

Open
lm-n opened this issue Sep 20, 2018 · 4 comments
Open

look into vulnerabilities #130

lm-n opened this issue Sep 20, 2018 · 4 comments
Assignees
@lm-n

Comments

@lm-n
Copy link
Member

lm-n commented Sep 20, 2018

No description provided.

@lm-n lm-n self-assigned this Sep 20, 2018
@lm-n lm-n added the ver0.2.0 label Sep 20, 2018
@lm-n
Copy link
Member Author

lm-n commented Sep 23, 2018

@spiray can we look for an alternative to grunt open?

@spiray
Copy link
Contributor

spiray commented Sep 26, 2018

@lm-n We would have to change the testing approach completely without open.

  1. Do you want to see what the other p5 libraries are doing first?
  2. Does this vulnerability even matter to us if it is strictly a devDependency and it isn't subject to injection. Am i understanding the vulnerability correctly?

@mithru
Copy link
Collaborator

mithru commented Sep 30, 2018

@spiray I believe you're right about it just being a devDependency. The only reason why we might want to change is for newer people wanting to contribute to the library. I think we should skip this for now, and discuss this after 0.2.0

@spiray
Copy link
Contributor

spiray commented Oct 4, 2018

@mithru OK. Can you remove the ver0.2.0 tag?

@mithru mithru removed the ver0.2.0 label Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lm-n lm-n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mithru @lm-n @spiray