Skip to content

Conversation

@csouchet
Copy link
Contributor

@csouchet csouchet commented Nov 17, 2021

Covers #187

  • Remove duplication between Post and News sections
    • Merge Post and old PostContainer classes
    • Add a content property in new PostContainer class: posts or news can be passed to the component
  • The new PostContainer class has a new pageId property: when set, it limits the number of cards to 6 and create a 'More' button linked to the page passed as property
  • The More button uses the same style as the Card.

@csouchet csouchet added the enhancement New feature or request label Nov 17, 2021
@github-actions
Copy link

github-actions bot commented Nov 17, 2021

♻️ PR Preview 6c49c18 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet
Copy link
Contributor Author

csouchet commented Nov 17, 2021

Rendering examples

1

image

2

image

3

image

4

image

5

image

6

image

7

image

8

image

9

image

10

image

11

image

12

image

@csouchet csouchet force-pushed the 187-Don_t_display_all_the_posts_in_the_home_page branch from 2fcc3f0 to 0292083 Compare November 17, 2021 16:16
@csouchet csouchet requested a review from tbouffard November 18, 2021 13:32
@csouchet
Copy link
Contributor Author

On hover

image

@csouchet csouchet force-pushed the 187-Don_t_display_all_the_posts_in_the_home_page branch from 3152308 to 93d6417 Compare November 19, 2021 15:14
@csouchet csouchet marked this pull request as ready for review November 19, 2021 16:35
@csouchet csouchet changed the title [FEAT] Don't display all the posts in the Blog section of the Home page [FEAT] Don't display all the posts in the 'Blog' section of the 'Home' page Nov 19, 2021
@tbouffard
Copy link
Member

⚠️ on small screen with d066228, the more button may appear in the blue triangle. In this case, it is not visible. With a white background in the a element, this fixes the problem.

current background proposed white background
more_button_01_no_background_color more_button_02_white_background_color

@csouchet
Copy link
Contributor Author

csouchet commented Nov 22, 2021

⚠️ on small screen with d066228, the more button may appear in the blue triangle. In this case, it is not visible. With a white background in the a element, this fixes the problem.

Fixed

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ preview checked on desktop (including responsiveness) and mobile (iOS)

@NathalieC
Copy link

Salut!

  1. Quick question: where does "More" lead to?
    My guess would be "more blog posts". Is that it? If not, you need to name on the button what I will find by clicking on the button.
  2. Then, depending on the criticality of the content to access, you can define the visual "strength" of the button: if it is very important content, it should be as bright and visible as "Demo" at the top of the page.
    If it secondary information it gives access to, then it can stay white.
  3. When you first visit the page, the button should not appear before all the Blog post tiles are displayed. Can it be delayed a bit?
  4. Then, when I scroll to the top of the page and back to the bottom again, it does not display anymore.

@csouchet csouchet merged commit f4249d8 into main Nov 22, 2021
@csouchet csouchet deleted the 187-Don_t_display_all_the_posts_in_the_home_page branch November 22, 2021 09:47
@tbouffard
Copy link
Member

@NathalieC the PR has been merged at the same time you posted your comment.
We have note your feedback and they are now integrated as a task in #187

  1. "more" leads to the blog posts page that hold all blog posts. So yes, it leads to what you call "more blog posts". We plan to replicate the button for use in the 'news' section.
  2. It is not as important as the "demo" element in the navbar, that's why we decided to put it in white
  3. and 4. We will look at this later

@csouchet
Copy link
Contributor Author

@NathalieC For the 4., I tried on Firefox, Safari & Chrome on macOS, and I didn't reproduce the problem.

For the 3., I plan to rework the display animations of the cards.
I will try to find a solution to show the buttons last at that time.

@NathalieC
Copy link

NathalieC commented Nov 25, 2021

Here is how I see the structure:
Home page as it is today. The 2 sections that may get a lot of content with time are "News" and "Blog".


So when you get to "News", you see at most 6 tiles (or eight) of news articles, and then the "More news articles" button.
And when you get to "Blog", you see at most 6 tiles (or eight) of blog posts, and then the "More blog posts" button.


When you click on "More news articles", you only see the "More news articles" title and content + a way to navigate back to the home page, like a "Home page" link at the top left of the screen.
When you click on "More blog posts", you only see the "More blog posts" title and content + the same way to navigate back to the home page.


On both "More news articles" and "More blog posts" pages, it's either about infinite scrolling, or pagination, and even maybe a search bar (?) to find a content you have heard about, or check if any post or article talks about something you are interested in.


So for me, it would really be 3 pages: the home, and 2 daughters that do not share anything.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants