-
Notifications
You must be signed in to change notification settings - Fork 4
[FEAT] Don't display all the posts in the 'Blog' section of the 'Home' page #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Don't display all the posts in the 'Blog' section of the 'Home' page #225
Conversation
|
♻️ PR Preview 6c49c18 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
2fcc3f0 to
0292083
Compare
3152308 to
93d6417
Compare
|
|
Fixed |
tbouffard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ preview checked on desktop (including responsiveness) and mobile (iOS)
|
Salut!
|
|
@NathalieC the PR has been merged at the same time you posted your comment.
|
|
@NathalieC For the 4., I tried on Firefox, Safari & Chrome on macOS, and I didn't reproduce the problem. For the 3., I plan to rework the display animations of the cards. |
|
Here is how I see the structure: So when you get to "News", you see at most 6 tiles (or eight) of news articles, and then the "More news articles" button. When you click on "More news articles", you only see the "More news articles" title and content + a way to navigate back to the home page, like a "Home page" link at the top left of the screen. On both "More news articles" and "More blog posts" pages, it's either about infinite scrolling, or pagination, and even maybe a search bar (?) to find a content you have heard about, or check if any post or article talks about something you are interested in. So for me, it would really be 3 pages: the home, and 2 daughters that do not share anything. |
















Covers #187
PostandNewssectionsPostand oldPostContainerclassesPostContainerclass: posts or news can be passed to the componentPostContainerclass has a newpageIdproperty: when set, it limits the number of cards to 6 and create a 'More' button linked to the page passed as propertyCard.