[REFACTOR] ProcessConverter: simplify event definitions retrieval

Previously, for a given 'bpmn element', we retrieved a list with all event
definitions that exist in the spec with the number of occurrences associated to
the 'bpmn element'.
It was not obvious that this list contained all definitions with some occurrence
counters set to zero:
  - generally, the intuition of the reader is to have only definitions for non
  zero counts.
  - in addition, the method documentation confirmed this intuition 'Get the list
  of eventDefinition hold by the Event bpmElement'. It never talked about zero
  counters
Second, this required an extra filtering to only get the definitions actually
hold by the bpmn element (only keep definitions with non zero counter).

The new implementation now returns only a list of event definitions with non
zero counter i.e. the event definitions declared in the BPMN definition with
their occurrence count. This method is in charge of the zero counter filtering,
letting the client code cleaner.

Author: tbouffard

src/component/parser/json/converter/ProcessConverter.ts

@@ -118,25 +118,29 @@ export default class ProcessConverter extends AbstractConverter<Process> {
     }
 
     if (numberOfEventDefinitions == 1) {
-      const eventDefinition = eventDefinitions.filter(eventDefinition => eventDefinition.counter == 1)[0];
+      const eventDefinition = eventDefinitions[0];
       if (supportedBpmnEventKinds.includes(eventDefinition.kind)) {
         return new ShapeBpmnEvent(bpmnElement.id, bpmnElement.name, elementKind, eventDefinition.kind, processId);
       }
     }
   }
 
   /**
-   * Get the list of eventDefinition hold by the Event bpmElement
+   * Get the list of eventDefinitions hold by the Event bpmElement
    *
    * @param bpmnElement The BPMN element from the XML data which represents a BPMN Event
    */
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   private getEventDefinitions(bpmnElement: any): EventDefinition[] {
-    return bpmnEventKinds.map(eventKind => {
-      // sometimes eventDefinition is simple and therefore it is parsed as empty string "", in that case eventDefinition will be converted to an empty object
-      const eventDefinition = bpmnElement[eventKind + 'EventDefinition'];
-      return { kind: eventKind, counter: ensureIsArray(eventDefinition, true).length };
-    });
+    return bpmnEventKinds
+      .map(eventKind => {
+        // sometimes eventDefinition is simple and therefore it is parsed as empty string "", in that case eventDefinition will be converted to an empty object
+        const eventDefinition = bpmnElement[eventKind + 'EventDefinition'];
+        return { kind: eventKind, counter: ensureIsArray(eventDefinition, true).length };
+      })
+      .filter(eventDefinition => {
+        return eventDefinition.counter > 0;
+      });
   }
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any