Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete the Host eader #300

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: delete the Host eader #300

merged 1 commit into from
Aug 15, 2024

Conversation

wolfy1339
Copy link
Contributor

Fixes #295
Fixes #187

Uzlopak
Uzlopak approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it but i think it is pointless because it is a forbidden header by spec anyway. So fetch should filter out host anyway.

@wolfy1339 wolfy1339 merged commit 50bb037 into master Aug 15, 2024
18 checks passed
@wolfy1339 wolfy1339 deleted the host-header branch August 15, 2024 01:00
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@WontonSam WontonSam mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

@JasonEtco JasonEtco Awaiting requested review from JasonEtco JasonEtco is a code owner

@tcbyrd tcbyrd Awaiting requested review from tcbyrd tcbyrd is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@wolfy1339 @Uzlopak