This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Use is_warm instead of is_cold for access list value#145
Merged
han0110 merged 1 commit intoMar 12, 2022
Merged
Conversation
0xmountaintop
approved these changes
Mar 12, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just realized using
is_warmas value of access list in real circuit seems more straightforward, so this PR aims to revert the change made in #132, and also update the usage of access list inBeginTx.(to be nitpicking, it should be
is_already_warmoris_warm_prevsince it's the previous value, but omittingalreadyorprevseems fine here)