Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Specs for EXTCODEHASH#139

Merged
icemelon merged 12 commits into
privacy-ethereum:masterfrom
scroll-tech:feat/extcodehash
Mar 14, 2022
Merged

Specs for EXTCODEHASH#139
icemelon merged 12 commits into
privacy-ethereum:masterfrom
scroll-tech:feat/extcodehash

Conversation

@z2trillion
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just added a minor comment for a typo. But a part from that, everything looks great!

Comment thread src/zkevm_specs/evm/execution/extcodehash.py Outdated
@z2trillion z2trillion requested a review from ed255 March 9, 2022 19:36
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

Comment thread src/zkevm_specs/evm/execution/extcodehash.py Outdated
Comment thread src/zkevm_specs/evm/execution/extcodehash.py Outdated
Comment thread src/zkevm_specs/util/param.py Outdated
Copy link
Copy Markdown
Collaborator

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to rebase to latest master again

Comment thread src/zkevm_specs/evm/execution/extcodehash.py Outdated
Comment thread src/zkevm_specs/evm/execution/extcodehash.py Outdated
Copy link
Copy Markdown
Collaborator

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icemelon icemelon merged commit 11ff5b4 into privacy-ethereum:master Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants