From 99a6cc56b2726f8c65f0daaba79682af2c85125f Mon Sep 17 00:00:00 2001 From: CPerezz Date: Fri, 8 Apr 2022 18:04:02 +0200 Subject: [PATCH 1/2] feat: Add PR requester for external reviewers Deprecates #438 and instead adds the external_reviewers to the PR reviews using a 3rd party application. That is done like this to avoid including a lot of people into `appliedzkp` org and granting custom permissions each time we want to add a new reviewer. Resolves: #429 completely. --- .github/reviewer-lottery.yml | 10 ++++++++++ .github/workflows/external_reviewers_assig.yml | 13 +++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 .github/reviewer-lottery.yml create mode 100644 .github/workflows/external_reviewers_assig.yml diff --git a/.github/reviewer-lottery.yml b/.github/reviewer-lottery.yml new file mode 100644 index 0000000000..cad974b577 --- /dev/null +++ b/.github/reviewer-lottery.yml @@ -0,0 +1,10 @@ +groups: + - name: external-zkevm-reviewers + reviewers: 1 + internal_reviewers: 1 + usernames: + - DreamWuGit + - HAOYUatHZ + - roynalnaruto + - lispc + - icemelon diff --git a/.github/workflows/external_reviewers_assig.yml b/.github/workflows/external_reviewers_assig.yml new file mode 100644 index 0000000000..d0769c601f --- /dev/null +++ b/.github/workflows/external_reviewers_assig.yml @@ -0,0 +1,13 @@ +name: "Reviewer lottery" +on: + pull_request: + types: [synchronize, opened, reopened, ready_for_review] + +jobs: + test: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v1 + - uses: uesteibar/reviewer-lottery@v2 + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} From 8d28c15b5b5a9b092bb54504d87a2ea4820331b6 Mon Sep 17 00:00:00 2001 From: CPerezz Date: Tue, 12 Apr 2022 14:16:46 +0200 Subject: [PATCH 2/2] Trigger workflow only when PR is opened Force-pushing to the PR currently re-triggers the workflow by assigning to the PR a new member of the team while mantaining the previous. That's an issue as we end up with multiple reviewers on each PR when indeed we just need one. See: https://github.com/uesteibar/reviewer-lottery/issues/26 for more details. --- .github/workflows/external_reviewers_assig.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/external_reviewers_assig.yml b/.github/workflows/external_reviewers_assig.yml index d0769c601f..70a457ed38 100644 --- a/.github/workflows/external_reviewers_assig.yml +++ b/.github/workflows/external_reviewers_assig.yml @@ -1,7 +1,7 @@ name: "Reviewer lottery" on: pull_request: - types: [synchronize, opened, reopened, ready_for_review] + types: [opened] jobs: test: