This repository was archived by the owner on Jul 5, 2024. It is now read-only.
fix/keccak-decode-overflow: calculate with bitshifts in u64#1262
Merged
CPerezz merged 1 commit intoFeb 27, 2023
Merged
Conversation
github-actions
Bot
added
the
crate-zkevm-circuits
CPerezz
approved these changes
Feb 27, 2023
CPerezz
left a comment
CPerezz
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Thanks for porting this here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
KECCAK_DEGREE=19,get_num_bits_per_absorb_lookup()is 11. In some places,2**3**11overflowsu32.Replace with
u64. Also use faster bitshifts like Axiom’s version.Issue Link
Port fix from Scroll scroll-tech#335
Type of change
Contents
u64How Has This Been Tested?