From e108fb19d0a84fa598e7ec0bfa68834d54bcbdb7 Mon Sep 17 00:00:00 2001
From: Soham Zemse <22412996+zemse@users.noreply.github.com>
Date: Fri, 23 Jun 2023 14:35:14 +0530
Subject: [PATCH 1/2] Derive num_instance from instances

---
 snark-verifier-sdk/src/lib.rs | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/snark-verifier-sdk/src/lib.rs b/snark-verifier-sdk/src/lib.rs
index da9d8db8..32c5d1dd 100644
--- a/snark-verifier-sdk/src/lib.rs
+++ b/snark-verifier-sdk/src/lib.rs
@@ -102,12 +102,17 @@ impl SnarkWitness {
 }
 
 pub trait CircuitExt<F: Field>: Circuit<F> {
-    /// Return the number of instances of the circuit.
+    /// Return the instances of the circuit.
     /// This may depend on extra circuit parameters but NOT on private witnesses.
-    fn num_instance(&self) -> Vec<usize>;
-
     fn instances(&self) -> Vec<Vec<F>>;
 
+    fn num_instance(&self) -> Vec<usize> {
+        self.instances()
+            .iter()
+            .map(|inst| inst.len())
+            .collect::<Vec<usize>>()
+    }
+
     fn accumulator_indices() -> Option<Vec<(usize, usize)>> {
         None
     }

From a8ab7f1acd7f2911b8d941eb7dcfa53c7adf4d1d Mon Sep 17 00:00:00 2001
From: soham <22412996+zemse@users.noreply.github.com>
Date: Sat, 1 Jul 2023 13:35:43 +0530
Subject: [PATCH 2/2] Update snark-verifier-sdk/src/lib.rs

Co-authored-by: Han <tinghan0110@gmail.com>
---
 snark-verifier-sdk/src/lib.rs | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/snark-verifier-sdk/src/lib.rs b/snark-verifier-sdk/src/lib.rs
index 32c5d1dd..fe9395dd 100644
--- a/snark-verifier-sdk/src/lib.rs
+++ b/snark-verifier-sdk/src/lib.rs
@@ -107,10 +107,7 @@ pub trait CircuitExt<F: Field>: Circuit<F> {
     fn instances(&self) -> Vec<Vec<F>>;
 
     fn num_instance(&self) -> Vec<usize> {
-        self.instances()
-            .iter()
-            .map(|inst| inst.len())
-            .collect::<Vec<usize>>()
+        self.instances().iter().map(Vec::len).collect()
     }
 
     fn accumulator_indices() -> Option<Vec<(usize, usize)>> {