From 109d407ab54773550b147149aff23a9ea63aeb98 Mon Sep 17 00:00:00 2001 From: Joel Hawksley Date: Fri, 10 Jan 2025 10:49:24 -0700 Subject: [PATCH 1/2] fix more benchmarks --- test/performance/bench_octicons.rb | 4 ++-- test/performance/bench_utilities.rb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/performance/bench_octicons.rb b/test/performance/bench_octicons.rb index fb23545dae..b9f033b90a 100644 --- a/test/performance/bench_octicons.rb +++ b/test/performance/bench_octicons.rb @@ -17,7 +17,7 @@ def setup def bench_allocations_without_cache Primer::Beta::Octicon.new(**@options) Primer::Octicon::Cache.clear! - assert_allocations "3.3" => 26, "3.2" => 26, "3.1" => 27, "3.0" => 27 do + assert_allocations "3.4" => 25, "3.3" => 26, "3.2" => 26, "3.1" => 27, "3.0" => 27 do Primer::Beta::Octicon.new(**@options) end ensure @@ -26,7 +26,7 @@ def bench_allocations_without_cache def bench_allocations_with_cache Primer::Octicon::Cache.preload! - assert_allocations "3.3" => 10, "3.2" => 10, "3.1" => 10, "3.0" => 10 do + assert_allocations "3.4" => 9, "3.3" => 10, "3.2" => 10, "3.1" => 10, "3.0" => 10 do Primer::Beta::Octicon.new(**@options) end end diff --git a/test/performance/bench_utilities.rb b/test/performance/bench_utilities.rb index 033427e30d..1fd208b865 100644 --- a/test/performance/bench_utilities.rb +++ b/test/performance/bench_utilities.rb @@ -12,7 +12,7 @@ def bench_allocations_supported_selector # warm up Primer::Classify::Utilities.supported_selector?("m-1") - assert_allocations "3.0" => 4, "3.1" => 4, "3.2" => 4, "3.3" => 4 do + assert_allocations "3.0" => 4, "3.1" => 4, "3.2" => 4, "3.3" => 4, "3.4" => 4 do Primer::Classify::Utilities.supported_selector?("m-1") end end @@ -21,7 +21,7 @@ def bench_allocations_non_supported_selector # warm up Primer::Classify::Utilities.supported_selector?("foo") - assert_allocations "3.0" => 0, "3.1" => 0, "3.2" => 0, "3.3" => 0 do + assert_allocations "3.0" => 0, "3.1" => 0, "3.2" => 0, "3.3" => 0, "3.4" => 0 do Primer::Classify::Utilities.supported_selector?("foo") end end From 06f7920e800fcfdcde93fa248d5d83a08356fe0b Mon Sep 17 00:00:00 2001 From: Joel Hawksley Date: Fri, 10 Jan 2025 10:50:38 -0700 Subject: [PATCH 2/2] Create great-students-wave.md --- .changeset/great-students-wave.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/great-students-wave.md diff --git a/.changeset/great-students-wave.md b/.changeset/great-students-wave.md new file mode 100644 index 0000000000..5edd01510a --- /dev/null +++ b/.changeset/great-students-wave.md @@ -0,0 +1,5 @@ +--- +"@primer/view-components": patch +--- + +Add more support for ruby 3.4 in tests