diff --git a/.changeset/silly-cherries-compare.md b/.changeset/silly-cherries-compare.md new file mode 100644 index 0000000000..081e22fb53 --- /dev/null +++ b/.changeset/silly-cherries-compare.md @@ -0,0 +1,5 @@ +--- +"@primer/view-components": patch +--- + +Bug: Remove dismissable flash stealing focus diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/banner/dismissible/default.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/banner/dismissible/default.png index 847983c793..c2cc445e6f 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/banner/dismissible/default.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/banner/dismissible/default.png differ diff --git a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/banner/dismissible/focused.png b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/banner/dismissible/focused.png index 262a1a8ea0..353cf82b5d 100644 Binary files a/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/banner/dismissible/focused.png and b/.playwright/screenshots/snapshots.test.ts-snapshots/primer/alpha/banner/dismissible/focused.png differ diff --git a/app/components/primer/alpha/banner.html.erb b/app/components/primer/alpha/banner.html.erb index ec1ef85ca1..67b7862b51 100644 --- a/app/components/primer/alpha/banner.html.erb +++ b/app/components/primer/alpha/banner.html.erb @@ -23,8 +23,7 @@ scheme: :invisible, icon: :x, aria: { label: @dismiss_label }, - data: { action: catalyst_action(event: "click", function: "dismiss") }, - autofocus: true + data: { action: catalyst_action(event: "click", function: "dismiss") } ) ) %>