Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormControl-spacingWrapper shows excessive whitespace when form has hidden inputs #3194

Open
gwwar opened this issue Nov 13, 2024 · 1 comment · May be fixed by #3202
Open

FormControl-spacingWrapper shows excessive whitespace when form has hidden inputs #3194

gwwar opened this issue Nov 13, 2024 · 1 comment · May be fixed by #3202
Assignees
@camertron
Labels
rails size: pebble

Comments

@gwwar
Copy link
Contributor

gwwar commented Nov 13, 2024 •
edited
Loading

Try creating a form with hidden inputs. The row-gap css rule adds extra whitespace.

To see an example live:

  • Visit github.com/pricing
  • Pick enterprise
  • Click to activate the enterprise
  • The billing information form has excess whitespace
extra space from hidden inputs disable row gap
Form with four extra lines of space at the top Form without spaces between inputs
@gwwar
Copy link
Contributor Author

gwwar commented Nov 13, 2024

Likely this file:

view_components/app/components/primer/alpha/text_field.pcss

Line 69 in fd3578b

row-gap: var(--stack-gap-normal);

@primer primer deleted a comment from github-actions bot Nov 13, 2024
This was referenced Nov 19, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camertron camertron

Labels
rails size: pebble
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent hidden inputs from taking up space on the page primer/view_components
3 participants
@camertron @gwwar @sunnyi101