Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchored position element align= attribute conflicting with html align attribute #2942

Open
jonrohan opened this issue Jul 10, 2024 · 1 comment
Labels

Comments

@jonrohan
Copy link
Member

https://primer-lookbook.github.com/view-components/lookbook/inspect/primer/alpha/overlay/middle_of_page?_display=%257B%2522theme%2522%253A%2522light%2522%257D&size=medium

I noticed that the in the Overlay when there's a menu with a header the title aligns strangely. I thought for a minute this was part of the design but realized that this is because the browser has a built in align= attribute.

Image

I think to fix this we should have the <anchored-position element use anchor-align and anchor-side. To support any existing cases we could have it use either. But we should update our components to output the non-conflicting attribute

Copy link
Contributor

Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant