Skip to content

Commit e9a4a60

Browse files
authored
Update test allocations to match latest ViewComponent alpha release (#3498)
1 parent 902b52c commit e9a4a60

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

.changeset/brown-readers-hug.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/view-components": patch
3+
---
4+
5+
Update test allocations to match latest ViewComponent alpha release.

Gemfile.lock

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ GEM
139139
zeitwerk (~> 2.5)
140140
marcel (1.0.4)
141141
matrix (0.4.2)
142-
method_source (1.1.0)
143142
mini_mime (1.1.5)
144143
mini_portile2 (2.8.8)
145144
minitest (5.25.5)
@@ -275,10 +274,9 @@ GEM
275274
unicode-display_width (2.6.0)
276275
uri (1.0.3)
277276
useragent (0.16.11)
278-
view_component (3.21.0)
279-
activesupport (>= 5.2.0, < 8.1)
280-
concurrent-ruby (~> 1.0)
281-
method_source (~> 1.0)
277+
view_component (4.0.0.alpha5)
278+
activesupport (>= 7.1.0, < 8.1)
279+
concurrent-ruby (~> 1)
282280
vite_rails (3.0.19)
283281
railties (>= 5.1, < 9)
284282
vite_ruby (~> 3.0, >= 3.2.2)

test/performance/bench_octicons.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def setup
1717
def bench_allocations_without_cache
1818
Primer::Beta::Octicon.new(**@options)
1919
Primer::Octicon::Cache.clear!
20-
assert_allocations "3.4" => 25, "3.3" => 26, "3.2" => 26, "3.1" => 27, "3.0" => 27 do
20+
assert_allocations "3.4" => 26, "3.3" => 30, "3.2" => 30, "3.1" => 28, "3.0" => 28 do
2121
Primer::Beta::Octicon.new(**@options)
2222
end
2323
ensure
@@ -26,7 +26,7 @@ def bench_allocations_without_cache
2626

2727
def bench_allocations_with_cache
2828
Primer::Octicon::Cache.preload!
29-
assert_allocations "3.4" => 9, "3.3" => 10, "3.2" => 10, "3.1" => 10, "3.0" => 10 do
29+
assert_allocations "3.4" => 10, "3.3" => 14, "3.2" => 14, "3.1" => 11, "3.0" => 11 do
3030
Primer::Beta::Octicon.new(**@options)
3131
end
3232
end

0 commit comments

Comments
 (0)