Skip to content

Commit cff3e11

Browse files
authored
Merge branch 'main' into kh-remove-autofocus
2 parents 70846eb + 77e59ee commit cff3e11

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

.changeset/sharp-walls-attend.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/view-components": patch
3+
---
4+
5+
Fix potential out-of-bounds error in ActionBar

app/components/primer/alpha/action_bar_element.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,13 +145,15 @@ class ActionBarElement extends HTMLElement {
145145
}
146146

147147
#showItem(index: number) {
148+
if (!this.items[index]) return
148149
this.items[index].style.setProperty('visibility', 'visible')
149-
this.#menuItems[index]!.hidden = true
150+
this.#menuItems[index].hidden = true
150151
}
151152

152153
#hideItem(index: number) {
154+
if (!this.items[index]) return
153155
this.items[index].style.setProperty('visibility', 'hidden')
154-
this.#menuItems[index]!.hidden = false
156+
this.#menuItems[index].hidden = false
155157
}
156158

157159
get #menuItems(): NodeListOf<HTMLElement> {

0 commit comments

Comments
 (0)