diff --git a/.changeset/poor-ducks-attack.md b/.changeset/poor-ducks-attack.md new file mode 100644 index 00000000000..feb0a437348 --- /dev/null +++ b/.changeset/poor-ducks-attack.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +fix(AnchoredOverlay): Omit aria-label and aria-labelledby from renderAnchor props diff --git a/packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx b/packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx index 6fb8d91f427..0ba6cf0b174 100644 --- a/packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx +++ b/packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx @@ -20,7 +20,9 @@ interface AnchoredOverlayPropsWithAnchor { * A custom function component used to render the anchor element. * Will receive the selected text as `children` prop when an item is activated. */ - renderAnchor: >(props: T) => JSX.Element + renderAnchor: , 'aria-label' | 'aria-labelledby'>>( + props: T, + ) => JSX.Element /** * An override to the internal ref that will be spread on to the renderAnchor diff --git a/packages/react/src/AnchoredOverlay/AnchoredOverlay.types.test.tsx b/packages/react/src/AnchoredOverlay/AnchoredOverlay.types.test.tsx new file mode 100644 index 00000000000..70239b61a49 --- /dev/null +++ b/packages/react/src/AnchoredOverlay/AnchoredOverlay.types.test.tsx @@ -0,0 +1,10 @@ +import {InfoIcon} from '@primer/octicons-react' +import {AnchoredOverlay, IconButton} from '..' + +export function itemWithIconElements() { + return ( + }> +

GitHub

+
+ ) +} diff --git a/packages/react/src/SelectPanel/SelectPanel.examples.stories.tsx b/packages/react/src/SelectPanel/SelectPanel.examples.stories.tsx index 05ccab9f5b9..00b57ebcba3 100644 --- a/packages/react/src/SelectPanel/SelectPanel.examples.stories.tsx +++ b/packages/react/src/SelectPanel/SelectPanel.examples.stories.tsx @@ -140,8 +140,8 @@ export const HeightInitialWithUnderflowingItemsAfterFetch = () => { Labels ( - )} @@ -172,8 +172,8 @@ export const AboveTallBody = () => { Labels ( - )} diff --git a/packages/react/src/SelectPanel/SelectPanel.features.stories.tsx b/packages/react/src/SelectPanel/SelectPanel.features.stories.tsx index 76193eeb64b..dd1fa062d03 100644 --- a/packages/react/src/SelectPanel/SelectPanel.features.stories.tsx +++ b/packages/react/src/SelectPanel/SelectPanel.features.stories.tsx @@ -582,13 +582,8 @@ export const AsyncFetch: StoryObj = { ( - )} @@ -656,8 +651,8 @@ export const CustomisedNoInitialItems = () => { ( - )} @@ -709,13 +704,8 @@ export const CustomisedNoResults: StoryObj = { ( - )}