From eef2cd4e6c77028db89d02756e548a15d9bd773c Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Wed, 3 Sep 2025 13:49:47 -0700 Subject: [PATCH 1/4] remove sx --- packages/react/src/SelectPanel/SelectPanel.module.css | 4 ++++ packages/react/src/SelectPanel/SelectPanel.tsx | 6 +----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/react/src/SelectPanel/SelectPanel.module.css b/packages/react/src/SelectPanel/SelectPanel.module.css index c1174442f80..d9dcd9a4fac 100644 --- a/packages/react/src/SelectPanel/SelectPanel.module.css +++ b/packages/react/src/SelectPanel/SelectPanel.module.css @@ -238,3 +238,7 @@ inset: 0; background-color: var(--overlay-backdrop-bgColor); } + +.TextInput { + margin: var(--base-size-8); +} \ No newline at end of file diff --git a/packages/react/src/SelectPanel/SelectPanel.tsx b/packages/react/src/SelectPanel/SelectPanel.tsx index 0e17c5c5958..455f67c6a5b 100644 --- a/packages/react/src/SelectPanel/SelectPanel.tsx +++ b/packages/react/src/SelectPanel/SelectPanel.tsx @@ -178,7 +178,6 @@ function Panel({ footer, textInputProps, overlayProps, - sx, loading, initialLoadingType = 'spinner', className, @@ -656,7 +655,7 @@ function Panel({ const extendedTextInputProps: Partial = useMemo(() => { return { - sx: {m: 2}, + className: classes.TextInput, contrast: true, leadingVisual: SearchIcon, 'aria-label': inputLabel, @@ -861,9 +860,6 @@ function Panel({ : EMPTY_MESSAGE.description || EMPTY_MESSAGE.description, }} fullScreenOnNarrow={usingFullScreenOnNarrow} - // inheriting height and maxHeight ensures that the FilteredActionList is never taller - // than the Overlay (which would break scrolling the items) - sx={sx} className={clsx(className, classes.FilteredActionList)} /> {footer ? ( From 25ad86db891b0c2c960d9daa0df2677c86800e23 Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Wed, 3 Sep 2025 13:50:31 -0700 Subject: [PATCH 2/4] changeset --- .changeset/lemon-jokes-camp.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/lemon-jokes-camp.md diff --git a/.changeset/lemon-jokes-camp.md b/.changeset/lemon-jokes-camp.md new file mode 100644 index 00000000000..d44b500b069 --- /dev/null +++ b/.changeset/lemon-jokes-camp.md @@ -0,0 +1,5 @@ +--- +'@primer/react': major +--- + +Remove sx prop support from the SelectPanel component. From 7f66996d8b9dec621e17eb406d114494b8776215 Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Wed, 3 Sep 2025 14:02:50 -0700 Subject: [PATCH 3/4] format --- packages/react/src/SelectPanel/SelectPanel.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/SelectPanel/SelectPanel.module.css b/packages/react/src/SelectPanel/SelectPanel.module.css index d9dcd9a4fac..deed7578fba 100644 --- a/packages/react/src/SelectPanel/SelectPanel.module.css +++ b/packages/react/src/SelectPanel/SelectPanel.module.css @@ -241,4 +241,4 @@ .TextInput { margin: var(--base-size-8); -} \ No newline at end of file +} From 595d693fd7e7e1ec05449b6436fd808c84e5876f Mon Sep 17 00:00:00 2001 From: Liu Liu Date: Mon, 8 Sep 2025 15:54:46 -0700 Subject: [PATCH 4/4] add comments to css --- packages/react/src/SelectPanel/SelectPanel.module.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react/src/SelectPanel/SelectPanel.module.css b/packages/react/src/SelectPanel/SelectPanel.module.css index deed7578fba..4a46aae1204 100644 --- a/packages/react/src/SelectPanel/SelectPanel.module.css +++ b/packages/react/src/SelectPanel/SelectPanel.module.css @@ -99,6 +99,8 @@ } .FilteredActionList { + /* inheriting height and maxHeight ensures that the FilteredActionList is never taller + than the Overlay (which would break scrolling the items) */ height: inherit; max-height: inherit; }