From 8121c73278cef08396b1ced274928a5206db7248 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Wed, 20 Dec 2023 10:16:52 +0100 Subject: [PATCH 1/2] don't show tooltip on :focus, only :focus-visible --- src/drafts/Tooltip/Tooltip.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/drafts/Tooltip/Tooltip.tsx b/src/drafts/Tooltip/Tooltip.tsx index 969e9f6a195..14be1e2a829 100644 --- a/src/drafts/Tooltip/Tooltip.tsx +++ b/src/drafts/Tooltip/Tooltip.tsx @@ -281,6 +281,8 @@ export const Tooltip = React.forwardRef( child.props.onBlur?.(event) }, onFocus: (event: React.FocusEvent) => { + // only show tooltip on :focus-visible, not on :focus + if (!event.target.matches(':focus-visible')) return; openTooltip() child.props.onFocus?.(event) }, From 299a17dadc572ed5c21b5aad739d6f0cbd259da3 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Thu, 4 Jan 2024 17:13:43 +0100 Subject: [PATCH 2/2] no semicolon geez --- src/drafts/Tooltip/Tooltip.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drafts/Tooltip/Tooltip.tsx b/src/drafts/Tooltip/Tooltip.tsx index 14be1e2a829..aa1387b303d 100644 --- a/src/drafts/Tooltip/Tooltip.tsx +++ b/src/drafts/Tooltip/Tooltip.tsx @@ -282,7 +282,7 @@ export const Tooltip = React.forwardRef( }, onFocus: (event: React.FocusEvent) => { // only show tooltip on :focus-visible, not on :focus - if (!event.target.matches(':focus-visible')) return; + if (!event.target.matches(':focus-visible')) return openTooltip() child.props.onFocus?.(event) },