-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation links point to obsolete documentation #123
Comments
Thanks for this @gtsiolis! :D |
@broccolini for the index page, should we change the |
We've also go the same links in our README |
Notes: let's change |
@emplums a link to the team is already included in the header navigation bar. Do you think adding a link to the team as the first CTA button on the index page could bring unnecessary and too much attention to the team page? If not, maybe the second link on the header bar could be removed, right? Also, what do you think about replacing Style Guide with Documentation and link to |
In future I'd like to update that to "about" so that it can be a space where we dive into why we open-source Primer, clarify that anyone can use it but the primary users are GitHub staff etc., as well as introduce the team. Until we add that content it can stay as Team though. |
@broccolini sorry for jumping in here again, but I'm only exploring Primer during the last days. What do you mean multiple frameworks? If you are referring to Primer CSS and Primer Components, I've included both links in the diff in the description for this specific reason. This would change the index links to: Documentation - Components - Community - Open-source. This could sound wrong, but I'll leave this to you. In any case, adding the link to the team as a less prominent link sounds good, but I could be wrong! 🏀 Also, About section and direction sound nice. |
Hey @gtsiolis just reviewed your PR as well. Regarding the multiple frameworks, we currently have tooling for CSS, React, and Rails so I the idea for this hero is to keep things general and then dive into which tools we offer further down in the page :) We've actually got some big design changes for this page coming soon that will help clear that up a bit! Thanks for the input and the PR! 🙌 |
Thanks @emplums! Again, sorry for jumping in here! I'll try to check the PR suggestions in a while!
Oh, I didn't know about the Rails one.
Sounds exciting! 🙌 |
Problem
The index page points to obsolete documentation. This is also related to #112 and #110.
See also primer/css#759.
Proposal
styleguide.github.com/primer
toprimer.style/css
.primer/primer/issues/new/choose
toprimer/css/issues/new/choose
.Possible fix
The text was updated successfully, but these errors were encountered: