Ellipsis

[ashygee]

No description provided.

[edokoa]

We have the normal vs. inverted versions. From the explorations I made, those are the sizes and distances that produce clean results. I think the left one doesn't work so well because the dots look too close, the inverted one has the same distance, but being white on black fixes a little bit the distance problem.

https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2?node-id=255%3A512

[edokoa]

Current version:

V1

V2

V3

[edokoa]

This icon is originally 12px. Should we make it in 24 instead of 16?

[colebemis]

This icon is originally 12px. Should we make it in 24 instead of 16?

No, we should still use the 16px grid.

[colebemis]

“Ellipses” has a different meaning than the similar “Kebab” icon so we should probably keep them visually different. According to our interface guidelines, “Ellipses” is for toggling truncated inline text content. “Kebab” is for toggling inline dropdowns and menus. https://primer.style/design/ui-patterns/progressive-disclosure#progressive-disclosure

V1 and V2 might be a little too similar to the “Kebab” icon unless we want to change “Ellipses” to just be a smaller “Kebab” icon.

[edokoa]

Then I'm fine with keeping the black box version.

[colebemis]

This is isn't being used in any public facing UI so I think we can remove the must label.

[edokoa]

Would we go with this one then?
https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=1109%3A3789

Do we need a 24px version?

[ashygee]

I think I prefer what you had going on here @edokoa

[edokoa]

With and without border here

https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=1119%3A3282

The solid one is closer to the current one, maybe the border one is complex for a small size. Would we need a 24px?

[colebemis]

I like the solid one ❤️ The outline one feels cluttered and blurry and I don't think there is a need for it. I'm okay with only having a solid version of this icon. Should we call it ellipsis-fill or just ellipsis?

Re: 24px — This icon is meant to be used inline with text so I can't imagine a 24px use for it.

[colebemis]

I opened a PR to add this to Octicons: primer/octicons#435

I'll merge when I have approvals from @ashygee and @edokoa