Skip to content

Commit e2cd01a

Browse files
author
Josep Martins
authored
About us link and style fixes (#613)
1 parent f876ded commit e2cd01a

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

.changeset/forty-paws-yawn.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@primer/gatsby-theme-doctocat': patch
3+
---
4+
5+
- Fix the primer navigation about link
6+
- Removes mono space font in the nav drawer + fontweight bold to match top left navigation

theme/src/components/header.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,12 @@ function PrimerNavItems({siteMetadata, items, path}) {
147147
<UnderlineNav aria-label="main navigation" sx={{border: 'none'}}>
148148
{items.map((item, index) => {
149149
return (
150-
<UnderlineNav.Link key={index} href={item.url} selected={item.url === siteMetadata.header.url + path}>
150+
<UnderlineNav.Link
151+
key={index}
152+
href={item.url}
153+
selected={item.url === siteMetadata.header.url + path}
154+
sx={{fontSize: 2, lineHeight: 'condensed'}}
155+
>
151156
{item.title}
152157
</UnderlineNav.Link>
153158
)

theme/src/components/nav-drawer.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ function NavDrawer({isOpen, onDismiss}) {
6060
}}
6161
>
6262
<Box sx={{py: 3, pl: 4, pr: 3, alignItems: 'center', justifyContent: 'space-between', display: 'flex'}}>
63-
<Link href="https://primer.style" sx={{fontFamily: 'mono', color: 'inherit'}}>
63+
<Link href="https://primer.style" sx={{fontWeight: 'bold', color: 'inherit'}}>
6464
Primer
6565
</Link>
6666
<Button aria-label="Close" onClick={onDismiss}>
@@ -86,7 +86,7 @@ function NavDrawer({isOpen, onDismiss}) {
8686
<Link
8787
as={GatsbyLink}
8888
to="/"
89-
sx={{display: 'inline-block', color: 'inherit', fontFamily: 'mono', mx: 4, mt: 4}}
89+
sx={{display: 'inline-block', color: 'inherit', fontWeight: 'bold', mx: 4, mt: 4}}
9090
>
9191
{siteMetadata.title}
9292
</Link>
@@ -111,7 +111,8 @@ function PrimerNavItems({items}) {
111111
borderRadius: 0,
112112
borderTopWidth: index !== 0 ? 1 : 0,
113113
borderColor: 'border.muted',
114-
p: 4,
114+
px: 4,
115+
py: 3,
115116
borderStyle: 'solid'
116117
}}
117118
>

theme/src/primer-nav.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
- title: Brand
22
url: https://primer.style/brand
33
- title: About
4-
url: https://primer.style/design/guides/about
4+
url: https://primer.style/design/about

0 commit comments

Comments
 (0)