Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - Escaped characters appearing in compiled CSS output #823

Open
rezrah opened this issue Nov 19, 2024 · 0 comments · May be fixed by #825
Open

🐛 [BUG] - Escaped characters appearing in compiled CSS output #823

rezrah opened this issue Nov 19, 2024 · 0 comments · May be fixed by #825
Assignees
@rezrah
Labels
brand bug Something isn't working

Comments

@rezrah
Copy link
Collaborator

rezrah commented Nov 19, 2024 •
edited
Loading

Describe the bug

Special characters are being unintentionally escaped in the compiled CSS stylesheet (main.css).

Example:

Source Compiled

Source code for river story scroll featuring a plus character

(Source)

Same CSS rule but as compiled output in unpkg

(Source)

Originally reported by @dgreif in Primer Brands slack channel

Reproduction steps

1. Go to https://unpkg.com/browse/@primer/[email protected]/lib/css/main.css and scroll down to styles for RiverStoryScroll
2. Observe that special characters are being escaped in contrast [the source code](https://github.com/primer/brand/blob/281beb08114f24f0ec5b23b14643324b0be532e6/packages/react/src/river/RiverStoryScroll/RiverStoryScroll.module.css#L150-L152)

Expected behavior

Special characters shouldn't be escaped in compiled output

Browsers

No response

OS

No response
@rezrah rezrah added brand bug Something isn't working labels Nov 19, 2024
@rezrah rezrah self-assigned this Nov 19, 2024
@rezrah rezrah linked a pull request Nov 20, 2024 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rezrah rezrah

Labels
brand bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates to compiled stylesheet primer/brand
1 participant
@rezrah