Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InputNumber clearTimer: clearInterval -> clearTimeout #7261

Merged

Conversation

ZolanPro
Copy link
Contributor

In some cases it may cause an infinite loop.
Caught this bug in my project. Unfortunately, I couldn't reproduce it on stackblitz, and couldn't identify specific reasons for this behavior.

Original code:
Timeout created:

this.timer = setTimeout(() => {
this.repeat(event, 40, dir);
}, i);

but interval cleared:

clearTimer() {
if (this.timer) {
clearInterval(this.timer);
}
},

Copy link

vercel bot commented Feb 16, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@tugcekucukoglu tugcekucukoglu added this to the 4.3.0 milestone Feb 19, 2025
@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Feb 19, 2025
@tugcekucukoglu tugcekucukoglu self-assigned this Feb 19, 2025
@tugcekucukoglu tugcekucukoglu merged commit 99559fe into primefaces:master Feb 19, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants