Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong types of the content slot in the fileupload component #7189

Closed
4 tasks
wangziling opened this issue Feb 5, 2025 · 0 comments · Fixed by #7188
Closed
4 tasks

Wrong types of the content slot in the fileupload component #7189

wangziling opened this issue Feb 5, 2025 · 0 comments · Fixed by #7188
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.3.0-rc.1

Comments

@wangziling
Copy link
Contributor

wangziling commented Feb 5, 2025 •
edited
Loading

Describe the bug

The FileUpload component shows that the messages in the content slot is string|undefined type, but in fact it should be string[]|null type according to its source code.

Pull Request Link

#7188

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-2avcjgqn?file=src%2FApp.vue

Environment

[email protected]
[email protected]

Vue version

3.5.13

PrimeVue version

4.2.5

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Use FileUpload component of the primevue package
  2. Specify a slot named content in it and use the slot props - messages.
  3. It shows that the messages is string|undefined type, but in fact it should be string[]|null type.

Expected behavior

The messages prop's type should be string[] | null.
@wangziling wangziling added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 5, 2025
@wangziling wangziling mentioned this issue Feb 5, 2025
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 5, 2025
@tugcekucukoglu tugcekucukoglu added this to the 4.3.0 milestone Feb 5, 2025
@tugcekucukoglu tugcekucukoglu self-assigned this Feb 5, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Feb 5, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeVue Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeVue
Status: Done
Milestone
4.3.0-rc.1
Development

Successfully merging a pull request may close this issue.

fix(fileupload): fix the types of the content slot wangziling/primevue
2 participants
@wangziling @tugcekucukoglu