Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormField: Missing attribute "name" in FormFieldProps #7145

Closed
4 tasks
abu-co opened this issue Jan 25, 2025 · 0 comments · Fixed by #7144
Closed
4 tasks

FormField: Missing attribute "name" in FormFieldProps #7145

abu-co opened this issue Jan 25, 2025 · 0 comments · Fixed by #7144
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.3.0-rc.1

Comments

@abu-co
Copy link
Contributor

abu-co commented Jan 25, 2025

Describe the bug

The attribute name should be a (perhaps required?) property in FormFieldProps.

Pull Request Link

#7144

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-m1hqz9ls

Environment

Vue 3 SFCs + vue-tsc 5.7.3 with strict template checking

Vue version

3.5.13

PrimeVue version

4.2.5

Node version

20.10.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Open reproducer
  2. Run npx vue-tsc --noEmit
  3. View undeclared property error

Expected behavior

The attribute name should be declared as part of FormFieldProps.
@abu-co abu-co added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 25, 2025
@abu-co abu-co mentioned this issue Jan 25, 2025
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 28, 2025
@tugcekucukoglu tugcekucukoglu added this to the 4.3.0 milestone Jan 28, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Jan 28, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeVue Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeVue
Status: Done
Milestone
4.3.0-rc.1
Development

Successfully merging a pull request may close this issue.

fix(forms): add name attribute to FormFieldProps abu-co/primevue-fork
2 participants
@tugcekucukoglu @abu-co