Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputOtp: Emit Options parameter type #6995

Closed
busyhuman opened this issue Dec 24, 2024 · 0 comments
Closed

InputOtp: Emit Options parameter type #6995

busyhuman opened this issue Dec 24, 2024 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@busyhuman
Copy link

busyhuman commented Dec 24, 2024

Describe the bug

스크린샷 2024-12-24 120022

I think some of emit options have wrong parameter type. They should be have string type, not boolean type in case of 'update:modelValue' and 'value-change'. 'change' event also should change type from 'Event' to like 'InputOtpChangeEvent'.

Reproducer

.

PrimeVue version

4.2.5

Vue version

3.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

chrome latest

Steps to reproduce the behavior

No response

Expected behavior

'update:modelValue'(value: string): void;
'value-change'(value: string): void;
change(event: InputOtpChangeEvent): void;

@busyhuman busyhuman added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 24, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Dec 26, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.2.6 milestone Dec 26, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Dec 26, 2024
@tugcekucukoglu tugcekucukoglu added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 26, 2024
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 27, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeVue Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

3 participants