Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer: no before-hide emit #6770

Closed
raizdev opened this issue Nov 12, 2024 · 2 comments
Closed

Drawer: no before-hide emit #6770

raizdev opened this issue Nov 12, 2024 · 2 comments
Assignees
@tugcekucukoglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
4.3.0-rc.1

Comments

@raizdev
Copy link

raizdev commented Nov 12, 2024

Describe the bug

I see there is no before-hide emit which means that I couldn't ask if the user wants to leave the drawer for example. Currently I am using drawer with builder in forms, means if user clicks outside div it immediately closes the drawer.

In my eyes its a benefit to add before-hide emit in drawer

Reproducer

PrimeVue version

4.1.2

Vue version

4.x

Language

ES6

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@raizdev raizdev added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 12, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.3.0 milestone Nov 13, 2024
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 13, 2024
@sivareddyuppathi sivareddyuppathi mentioned this issue Nov 14, 2024
Closed
@sivareddyuppathi
Copy link
Contributor

PR for above mentioned Enhancement.

#6787

@sivareddyuppathi sivareddyuppathi mentioned this issue Nov 22, 2024
Merged
@ataylor32
Copy link

Related (Dialog): https://github.com/orgs/primefaces/discussions/3289

@tugcekucukoglu tugcekucukoglu modified the milestones: 4.3.1, 4.3.0 Jan 7, 2025
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 7, 2025
@github-project-automation github-project-automation bot moved this to Done in PrimeVue Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
PrimeVue
Status: Done
Milestone
4.3.0-rc.1
Development

No branches or pull requests
4 participants
@ataylor32 @raizdev @tugcekucukoglu @sivareddyuppathi