Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: "loadingicon" slot has no class and data attribute #6747

Closed
Stawlie opened this issue Nov 8, 2024 · 0 comments · Fixed by #6765
Closed

Button: "loadingicon" slot has no class and data attribute #6747

Stawlie opened this issue Nov 8, 2024 · 0 comments · Fixed by #6765
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.2.2

Comments

@Stawlie
Copy link
Contributor

Stawlie commented Nov 8, 2024

Describe the bug

When using the "loadingicon" slot, its props do not have a class from ptOptions and a default "loadingicon" data attribute.

Reproducer

https://stackblitz.com/edit/primevue-4-ts-vite-issue-template-gr1wtj?file=src%2FApp.vue

PrimeVue version

4.2.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Stawlie Stawlie added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 8, 2024
@Stawlie Stawlie mentioned this issue Nov 12, 2024
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 13, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.2.2 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.2.2
Development

Successfully merging a pull request may close this issue.

Button: Added "loadingIcon" and "icon" pt options to its slots Stawlie/primevue
2 participants
@tugcekucukoglu @Stawlie