Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select/MultiSelect: onOverlayLeave should not try and focus on Filter #6564

Closed
1Map opened this issue Oct 12, 2024 · 2 comments
Closed

Select/MultiSelect: onOverlayLeave should not try and focus on Filter #6564

1Map opened this issue Oct 12, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@1Map
Copy link
Contributor

1Map commented Oct 12, 2024 •
edited
Loading

Describe the bug

The following line in your code throws an error as filterInput is null:

focus(this.$refs.filterInput.$el);

primevue/packages/primevue/src/select/Select.vue

Line 710 in 22d6f8a

focus(this.$refs.filterInput.$el);

I do not think it should try and focus on the filter during onOverlayLeave as the filterInput is not always there (null)

Reproducer

N/A

PrimeVue version

Latest

Vue version

4.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@1Map 1Map added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 12, 2024
@1Map 1Map changed the title Select/MultiSelect: Undefined filterInput throws error if null Select/MultiSelect: onOverlayLeave should not try and focus on Filter Oct 12, 2024
@CCodam
Copy link

CCodam commented Oct 12, 2024

Duplicate of #6539 and #6545

@tugcekucukoglu
Copy link
Member

Duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@1Map @CCodam @tugcekucukoglu