DataTable - button click in a cell propagates to row-click

[juliepetrova]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Clicking on a button inside a row in PrimeVue's DataTable still triggers the row's onRowClick event, which causes unwanted navigation. The patch prevents this by checking if the click target has the class 'p-button' and halting further execution if it does (it is a workaround and not an actual solution of course). In this example the button is used to open a ConfirmPopup element which, when stopPropagation is applied, is misplaced. (#5929)

Here is the diff that solved my problem:

diff --git a/node_modules/primevue/datatable/index.mjs b/node_modules/primevue/datatable/index.mjs
index 47a9440..6bfe420 100644
--- a/node_modules/primevue/datatable/index.mjs
+++ b/node_modules/primevue/datatable/index.mjs
@@ -1467,6 +1467,9 @@ var script$8 = {
       });
     },
     onRowClick: function onRowClick(event) {
+      if(event.target.className.includes('p-button')) {
+        return;
+      };
       this.$emit('row-click', {
         originalEvent: event,
         data: this.rowData,

This issue body was partially generated by patch-package.

[sid-6581]

The same thing happens for regular anchors, and probably anything else clickable. It seems #6333 is likely responsible for the regression.

[colinatwork]

We are also seeing this