Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog: shifting content under a modal window #6089

Closed
slider23 opened this issue Jul 21, 2024 · 6 comments
Closed

ConfirmDialog: shifting content under a modal window #6089

slider23 opened this issue Jul 21, 2024 · 6 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@slider23
Copy link

Describe the bug

Primevue 4 ConfirmDialog has classic modal UI issue - content (or only right edge of content - on small screens) shifting on browsers with non-zero scrollbar widths.
For example, Chrome on Linux.
Primevue 3 is free from such a issue.
See the gif:

Reproducer

https://primevue.org/confirmdialog/

PrimeVue version

4

Vue version

4.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

Any browser on Linux or Windows (not MacOs)

Steps to reproduce the behavior

  1. Go to https://primevue.org/confirmdialog/
  2. Click any "Save" button
  3. After modal window is displayed, the page content under modal window is shifted to the right by 15px.

Expected behavior

Сontent under the modal window should not shift. Like on https://v3.primevue.org/confirmdialog/

@slider23 slider23 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 21, 2024
@murshex
Copy link

murshex commented Aug 28, 2024

Same problem

@KumJungMin
Copy link
Contributor

KumJungMin commented Sep 1, 2024

  • In v4, the scroll blocking function has been moved to primeuix.
  • Additionally, testing the scroll function reveals that variableData is coming up as null,
  • which is preventing the function from executing correctly.

https://github.com/primefaces/primeuix/blob/main/packages/utils/src/dom/helpers/blockBodyScroll.ts#L6

스크린샷 2024-09-01 오후 10 03 57

@Olakeen
Copy link

Olakeen commented Dec 6, 2024

Same problem

@ayugioh2003
Copy link

I have the same problem on Windows Chrome

@craigjamesdobson
Copy link

Yeah, same problem here. Any updates on this?

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2025
@mertsincan mertsincan added this to the 4.3.0 milestone Jan 15, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeVue Jan 15, 2025
@mertsincan mertsincan self-assigned this Jan 15, 2025
@mertsincan
Copy link
Member

Fixed for the next version.

@github-project-automation github-project-automation bot moved this from Review to Done in PrimeVue Jan 28, 2025
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

8 participants