Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In primevue-nuxt-module Button as NuxtLink not working #6038

Closed
projct1 opened this issue Jul 9, 2024 · 3 comments
Closed

In primevue-nuxt-module Button as NuxtLink not working #6038

projct1 opened this issue Jul 9, 2024 · 3 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@projct1
Copy link

projct1 commented Jul 9, 2024

Describe the bug

With module primevue-nuxt-module, the links should be converted to the NuxtLink, not RouterLink, which is logical.

Reproducer

https://stackblitz.com/edit/nuxt-starter-fe8efa?file=app.vue

PrimeVue version

4.0.0

Vue version

3.x

Language

ES6

Build / Runtime

Nuxt

Browser(s)

Any

Steps to reproduce the behavior

https://stackblitz.com/edit/nuxt-starter-fe8efa?file=app.vue

image

Expected behavior

Transforms to NuxtLink component.

@projct1 projct1 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 9, 2024
@JPustkuchen
Copy link

Could we please extend this issue to all "Menu" components? It's the same issue. Any maintainer plans to fix this?

@mertsincan
Copy link
Member

@projct1, sorry but I don't understand your screenshot. In stackblitz link, your first example uses NuxtLink and the other uses RouterLink. 🤔 Coming back to the main problem, Button uses <component :is="as" structure so, this is related to nuxtjs; nuxt/nuxt#13659

@JPustkuchen, The menu components do not use any router APIs. You can integrate it using templating.

@JPustkuchen
Copy link

@mertsincan thanks for the quick reply! Yes, I saw it was removed. My question is - can it be done centrally?
Especially for the nuxt primevue module https://nuxt.com/modules/primevue it would be best to integrate the nuxt routing / NuxtLink. That's what I think Nuxt users would expect (and love ;))

Can it only be integrated by templating in each instance of <Menu>, etc. or, maybe until it's part of the module, in any central place? (Maybe it could also be documented there, until integrated).

Sorry, I'm very new to PrimeVue and didn't find fitting documentation for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants