-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] incorrect background colors #5894
Comments
Seems to be the reason for #5890 |
I did not use any popup thought. I only have fieldsets and buttons at the moment |
The entire Dark theme backgrounds are transparent now. I upgraded from beta 4 to rc1 and it changed. If you check out any component on the PrimeVue site like the Thanks. |
It seems the commit at fault is a054a92 I managed to temporarily revert the problem by copying a part of the definePreset in the documentation which was not updated alongside the commit. Thanks, |
Fixed in de2560a |
Describe the bug
Hello,
Colors breaks from [email protected] where they worked well on beta4
Fieldset and Card are perfect white in light mode and transparent in darkmode. --p-content-background is defined to those colors.
Reproducer
https://stackblitz.com/edit/primevue-create-vue-issue-template
PrimeVue version
4.0.0-rc.1
Vue version
3.x
Language
TypeScript
Build / Runtime
Vue CLI App
Browser(s)
Edge, chrome
Steps to reproduce the behavior
I use the following configuration from documentation:
// Initialize Prime vue
app.use(PrimeVue, {
theme: {
preset: Aura,
options: {
prefix: 'p',
darkModeSelector: 'system', // setting this to a class sets the background to pure white (p-surface-0 ffffff)
cssLayer: true // Changing this value did not seem to change a single thing.
}
},
ripple: true
});
I don't have any customization of the style variables or whatsoever
Expected behavior
The background colors or the components should have dark colors in dark mode and light colors (I'm guessing not perfect white) in light mode.
The text was updated successfully, but these errors were encountered: