Tooltip: Malfunction inside Links

[havist]

Describe the bug

There is a serious bug with Tooltip when it's used inside Links. When so, it causes the infinite recursion when trying to bind listeners using Tooltip's bindScrollListener() method resulting with Uncaught RangeError: Maximum call stack size exceeded. The problem lies in DomHandler.getScrollableParents() utility that cannot properly read parent nodes. That's because in described case the condition checking parent for null in DomHandler's code below does not work (parent is undefined instead).

getParents: function getParents(element) {
    var parents = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : [];
    var parent = this.getParentNode(element);
    return parent === null ? parents : this.getParents(parent, parents.concat([parent]));
},

Reproducer

https://codesandbox.io/p/sandbox/hungry-gagarin-nm9xwy

PrimeVue version

3.45.0

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Try the code in Sandbox and see the console.

Expected behavior

Tooltip should work w/o errors.

[tugcekucukoglu]

Cannot open the codesandbox demo. Could you update the link?

[havist]

Well, could you try this share link then, please?

[vaibs30]

Do we have an update here?
It is certainly reproducible and in the case of Safari, the whole page hangs.

[mertsincan]

Thanks a lot, @vaibs30! We'll check before the next version release. Sorry for the delayed response!

Best Regards,

[mattlyons0]

Hey I noticed this was supposed to be released in 3.47.0 recently but I'm not seeing it as fixed nor the changes in the published sources.

Here's an updated sandbox link to 3.47.1 where you can still reproduce the issue: https://codesandbox.io/p/devbox/hopeful-roman-dwn2qp
And if I open the sources of the installed package (node_modules/primevue/utils/utils.js) I still see the old logic in the built source:

getParentNode: function getParentNode(element) {
        var parent = element === null || element === void 0 ? void 0 : element.parentNode;
        if (parent && parent.host) {
          parent = parent.host;
        }
        return parent;
      },

(notice there is no reference to the added instanceof ShadowRoot check anywhere in the file)

See in browser via https://www.runpkg.com/[email protected]/utils/utils.js#368

[mertsincan]

Sorry for the confusion :/ There was confusion while merging from a different branch to master. I fixed it now. #5146 We will release the new version today. Thanks a lot for your report!

[mattlyons0]

No worries! Can confirm I'm seeing the fix in 3.47.2. Thanks