Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table columns with null values not sorted properly #4716

Closed
fprijate opened this issue Oct 30, 2023 · 2 comments
Closed

Table columns with null values not sorted properly #4716

fprijate opened this issue Oct 30, 2023 · 2 comments

Comments

@fprijate
Copy link

fprijate commented Oct 30, 2023

Describe the bug

[email protected] sorted columns with null values correctly.
Later versions 3.36.0 - 3.38.1 treats them as the biggest values (bottom of the table.)
IMHO there is a problem with #4555. I didn't check it

Reproducer

Sort the name or category column

https://stackblitz.com/edit/4ulyna?file=src%2Fservice%2FProductService.js

PrimeVue version

3.38.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

chrome 118.0

Steps to reproduce the behavior

on stackblitz sort the name or category column

Expected behavior

to sort correctly

@fprijate fprijate added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 30, 2023
@FlipWarthog
Copy link
Contributor

There's now a nullSortOrder prop to configure this behavior: https://primevue.org/datatable/#api.datatable.props.nullSortOrder

@tugcekucukoglu
Copy link
Member

nullSortOrder solves the problem.

Thank you @FlipWarthog

@tugcekucukoglu tugcekucukoglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants