Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverlayPanel: closeOnEscape broken #4693

Closed
Rakasch opened this issue Oct 25, 2023 · 3 comments
Closed

OverlayPanel: closeOnEscape broken #4693

Rakasch opened this issue Oct 25, 2023 · 3 comments
Assignees
@tugcekucukoglu
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.38.0

Comments

@Rakasch
Copy link
Contributor

Rakasch commented Oct 25, 2023

Describe the bug

I have an OverlayPanel with closeOnEscape set to false.
The OverlaPanel DOES close if I hit escape.

Reproducer

https://stackblitz.com/edit/yfzpcc?file=src%2FApp.vue

PrimeVue version

3.37.0

Vue version

3.x

Language

ES6

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Click the button to open the Overlaypanel.
  2. Hit escape.
    =>
    The Overlaypanel closes, despite having :closeOnEscape=false

Expected behavior

No response
@Rakasch Rakasch added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 25, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Oct 25, 2023
@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 25, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.38.0 milestone Oct 25, 2023
@Rakasch
Copy link
Contributor Author

Rakasch commented Oct 26, 2023

@tugcekucukoglu
Hi tugce,
I have looked at the commit b0fa143.
Can you double check, that doesn't look right to me.
If closeOnEscape is true, the overlay will always close no matter what key you press.

@Rakasch
Copy link
Contributor Author

Rakasch commented Oct 26, 2023

The bug must have something to do with the input having focus.
If the input has no focus, the closeOnEscape works correctly.

@Rakasch Rakasch mentioned this issue Oct 30, 2023
Closed
@Rakasch
Copy link
Contributor Author

Rakasch commented Nov 2, 2023 •
edited
Loading

for the record: fixed here #4717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.38.0
Development

No branches or pull requests
2 participants
@Rakasch @tugcekucukoglu