Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Tailwind setup - the Ripple data attributes get added automatically #4564

Closed
LanFeusT23 opened this issue Oct 5, 2023 · 0 comments
Closed
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@LanFeusT23
Copy link
Contributor

Describe the bug

Using tailwind setup the Ripple data attributes gets added to Buttons. Even when trying to disable ripple via { ripple: false } in the config.

This causes the ripple classes to be more specific than tailwind classes, preventing the use of certain classes, such as absolute

Reproducer

https://stackblitz.com/edit/vitejs-vite-upvqkv?file=src%2FApp.vue

PrimeVue version

3.34.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

All

Steps to reproduce the behavior

  1. Create an application using the Tailwind setup as described here: https://primevue.org/tailwind/
  2. Add a Button component and give it the classes absolute top-0

=> the Button is not positioned absolutely because:

  1. the Ripple attribute gets added and it's css overrides absolute
*[data-pd-ripple="true"] {
    overflow: hidden;
    position: relative;
}
  1. the Button by default gets several classes added to it, including relative which also overrides absolute

Expected behavior

Any manually added tailwind classes to a component should be the main class.

@LanFeusT23 LanFeusT23 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 5, 2023
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 10, 2023
@mertsincan mertsincan added this to the 3.35.1 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants